Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PublicTerminalCore APIset usage on Windows 7 #4733

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

ZoeyR
Copy link
Contributor

@ZoeyR ZoeyR commented Feb 27, 2020

Summary of the Pull Request

The new UIA code in PublicTerminalCore broke windows 7 support by referring to API set dlls for UIA. This PR changes the link line to link to UIAutomationcore.dll directly.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Terminal run on a windows 7 VM to ensure correct behavior.

@DHowett-MSFT DHowett-MSFT changed the title fix publicterminalcore on windows 7 Fix PublicTerminalCore APIset usage on Windows 7 Feb 27, 2020
@DHowett-MSFT DHowett-MSFT merged commit 9f53107 into master Feb 27, 2020
@DHowett-MSFT DHowett-MSFT deleted the dev/zorio/win7-link-line branch February 27, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants